Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1807343002: Add Physical Web UMA for ListUrlsActivity referers (Closed)

Created:
4 years, 9 months ago by cco3
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Physical Web UMA for ListUrlsActivity referers Instead of just recording metrics on notification presses, this change records metrics on other referers to the ListUrlsActivity and also records the delay between a notification update and pressing arriving at the ListUrlsActivity via a notification. BUG=594195 Committed: https://crrev.com/05a1aa568802b10f6bd3e150cfe4a72423f44fb2 Cr-Commit-Position: refs/heads/master@{#382044}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java View 1 chunk +1 line, -1 line 1 comment Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java View 14 chunks +67 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 2 chunks +20 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
cco3
4 years, 9 months ago (2016-03-17 19:25:06 UTC) #2
mattreynolds
LGTM https://codereview.chromium.org/1807343002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java (left): https://codereview.chromium.org/1807343002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java#oldcode237 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:237: intent.putExtra(ListUrlsActivity.REFERER_KEY, ListUrlsActivity.OPTIN_REFERER); Thanks for catching this
4 years, 9 months ago (2016-03-17 21:24:45 UTC) #3
cco3
4 years, 9 months ago (2016-03-17 21:27:17 UTC) #5
rkaplow
lgtm
4 years, 9 months ago (2016-03-18 14:59:22 UTC) #6
newt (away)
rs lgtm
4 years, 9 months ago (2016-03-18 17:38:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807343002/1
4 years, 9 months ago (2016-03-18 18:05:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 19:18:26 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 19:20:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05a1aa568802b10f6bd3e150cfe4a72423f44fb2
Cr-Commit-Position: refs/heads/master@{#382044}

Powered by Google App Engine
This is Rietveld 408576698