Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5121)

Unified Diff: chrome/browser/local_discovery/storage/privet_filesystem_operations.cc

Issue 180733006: [Privet Filesystem] Fix null dereference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/local_discovery/storage/privet_filesystem_operations.cc
diff --git a/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc b/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc
index 99e9c2febcd2557cdb7494e1c2af96f5e9b353b4..a7095ae3193b788ab7eea15b823cb79007999425 100644
--- a/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc
+++ b/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc
@@ -149,15 +149,15 @@ void PrivetFileSystemListOperation::OnStorageListResult(
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
list_operation_.reset();
- attribute_cache_->AddFileInfoFromJSON(full_path_, value);
-
- fileapi::AsyncFileUtil::EntryList entry_list;
-
if (!value) {
SignalError();
return;
}
+ attribute_cache_->AddFileInfoFromJSON(full_path_, value);
+
+ fileapi::AsyncFileUtil::EntryList entry_list;
+
const base::ListValue* entries;
if (!value->GetList(kPrivetListEntries, &entries)) {
SignalError();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698