Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180733006: [Privet Filesystem] Fix null dereference (Closed)

Created:
6 years, 9 months ago by Noam Samuel
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Privet Filesystem] Fix null dereference Fix null dereference issue in privet filesystem if listing a directory errors out. Instead, signal an error. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255430

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/local_discovery/storage/privet_filesystem_operations.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Noam Samuel
6 years, 9 months ago (2014-03-05 21:35:42 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm Snapshot is invalid.
6 years, 9 months ago (2014-03-05 21:46:39 UTC) #2
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-05 21:49:23 UTC) #3
Noam Samuel
On 2014/03/05 21:46:39, Vitaly Buka wrote: > lgtm > > Snapshot is invalid. Re-uploaded
6 years, 9 months ago (2014-03-05 21:49:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/180733006/40001
6 years, 9 months ago (2014-03-05 21:52:46 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 22:42:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-05 22:42:22 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-05 23:41:35 UTC) #8
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-05 23:41:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/180733006/40001
6 years, 9 months ago (2014-03-06 00:03:56 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:13:56 UTC) #11
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=156156
6 years, 9 months ago (2014-03-06 01:13:56 UTC) #12
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-06 18:31:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/180733006/40001
6 years, 9 months ago (2014-03-06 18:34:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/180733006/40001
6 years, 9 months ago (2014-03-06 20:55:52 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 21:13:13 UTC) #16
Message was sent while issue was closed. 
Change committed as 255430

Powered by Google App Engine
This is Rietveld 408576698