third_party/WebKit/Source/core/inspector/NetworkResourcesData.h - Issue 1807323002: [WeakMemoryCache 1a] Make Reference from Inspector to Resource weak, remove removedFromMemoryCache()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

Issue 1807323002: [WeakMemoryCache 1a] Make Reference from Inspector to Resource weak, remove removedFromMemoryCache() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove some comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

diff --git a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.h b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

index daa12192db1aa7c34db6dbed8f7d2f3310511774..bdb7c6070aa79b04c2a2a30a01ee26ef2fc61299 100644

--- a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

+++ b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

@@ -121,7 +121,7 @@ public:

void setBuffer(PassRefPtr<SharedBuffer> buffer) { m_buffer = buffer; }

Resource* cachedResource() const { return m_cachedResource.get(); }

- void setResource(Resource* cachedResource) { m_cachedResource = cachedResource; }

+ void setResource(Resource*);

XHRReplayData* xhrReplayData() const { return m_xhrReplayData.get(); }

void setXHRReplayData(XHRReplayData* xhrReplayData) { m_xhrReplayData = xhrReplayData; }

@@ -153,7 +153,7 @@ public:

OwnPtr<TextResourceDecoder> m_decoder;

RefPtr<SharedBuffer> m_buffer;

- Member<Resource> m_cachedResource;

+ WeakMember<Resource> m_cachedResource;

RefPtr<BlobDataHandle> m_downloadedFileBlob;

};