third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp - Issue 1807323002: [WeakMemoryCache 1a] Make Reference from Inspector to Resource weak, remove removedFromMemoryCache()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp

Issue 1807323002: [WeakMemoryCache 1a] Make Reference from Inspector to Resource weak, remove removedFromMemoryCache() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove some comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/Resource.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorInstrumentationCustomInl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp

index 3256cbe3eb99c6b898cefa26823664fada4beb41..2919da4a23ffbb7d8d27df4d48a69babc7945db6 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp

@@ -186,14 +186,14 @@ void continueWithPolicyIgnore(LocalFrame* frame, DocumentLoader* loader, unsigne

didReceiveResourceResponseButCanceled(frame, loader, identifier, r);

}

-void removedResourceFromMemoryCache(Resource* cachedResource)

+void willDestroyResource(Resource* cachedResource)

{

ASSERT(isMainThread());

for (InstrumentingAgents* instrumentingAgents: instrumentingAgentsSet()) {

if (!instrumentingAgents->hasInspectorResourceAgents())

continue;

for (InspectorResourceAgent* resourceAgent : instrumentingAgents->inspectorResourceAgents())

- resourceAgent->removedResourceFromMemoryCache(cachedResource);

+ resourceAgent->willDestroyResource(cachedResource);

}