third_party/WebKit/Source/core/css/CSSStyleSheet.cpp - Issue 1807323002: [WeakMemoryCache 1a] Make Reference from Inspector to Resource weak, remove removedFromMemoryCache()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

Issue 1807323002: [WeakMemoryCache 1a] Make Reference from Inspector to Resource weak, remove removedFromMemoryCache() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove some comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp b/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

index 5ea93ee906e04d3747e7012bb972fa34efaa2a3c..d715f78fbc66c0be0b8b01c01389ff72722d8af6 100644

--- a/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

+++ b/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

@@ -138,7 +138,7 @@ CSSStyleSheet::~CSSStyleSheet()

void CSSStyleSheet::willMutateRules()

{

// If we are the only client it is safe to mutate.

- if (m_contents->clientSize() <= 1 && !m_contents->isInMemoryCache()) {

+ if (m_contents->clientSize() <= 1 && !m_contents->isReferencedFromResource()) {

m_contents->clearRuleSet();

if (Document* document = ownerDocument())

m_contents->removeSheetFromCache(document);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp » ('j') | no next file with comments »