third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h - Issue 1807323002: [WeakMemoryCache 1a] Make Reference from Inspector to Resource weak, remove removedFromMemoryCache()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

Issue 1807323002: [WeakMemoryCache 1a] Make Reference from Inspector to Resource weak, remove removedFromMemoryCache() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: auto-Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/StyleSheetContents.h ('K') | « third_party/WebKit/Source/core/css/StyleSheetContents.cpp ('k') | third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

diff --git a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

index 0e60508c9e103a2676b49f0be6934c0d421595ea..e8890cd8fb09262764bcdda5346caf6f8d49131b 100644

--- a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

+++ b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

@@ -74,11 +74,14 @@ private:

CSSStyleSheetResource(const ResourceRequest&, const ResourceLoaderOptions&, const String& charset);

bool canUseSheet(MIMETypeCheck) const;

- void removedFromMemoryCache() override;

void checkNotify() override;

+ void willDestroyResourceInternal() override;

+ void setParsedStyleSheetCache(StyleSheetContents*);

String m_decodedSheetText;

+ // Call setParsedStyleSheetCache() to set/clear.

rune 2016/05/09 07:32:47 I don't think this comment adds much value.

hiroshige 2016/05/10 06:32:55 Done.

Member<StyleSheetContents> m_parsedStyleSheetCache;

};