[WeakMemoryCache 1a] Make Reference from Inspector to Resource weak, remove removedFromMemoryCache()

third_party/WebKit/Source/core/fetch/Resource.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 209 matching lines @@
     , m_decodedSize(0)
     , m_overheadSize(calculateOverheadSize())
     , m_preloadCount(0)
     , m_cacheIdentifier(MemoryCache::defaultCacheIdentifier())
     , m_preloadResult(PreloadNotReferenced)
     , m_type(type)
     , m_status(NotStarted)
     , m_needsSynchronousCacheHit(false)
     , m_linkPreload(false)
 {
+    ThreadState::current()->registerPreFinalizer(this);
+
     ASSERT(m_type == unsigned(type)); // m_type is a bitfield, so this tests careless updates of the enum.
     InstanceCounters::incrementCounter(InstanceCounters::ResourceCounter);
 
     // Currently we support the metadata caching only for HTTP family.
     if (m_resourceRequest.url().protocolIsInHTTPFamily())
         m_cacheHandler = CacheHandler::create(this);
 }
 
 Resource::~Resource()
 {
     InstanceCounters::decrementCounter(InstanceCounters::ResourceCounter);
 }
 
-void Resource::removedFromMemoryCache()
+void Resource::willDestroyResource()
 {
-    InspectorInstrumentation::removedResourceFromMemoryCache(this);
+    InspectorInstrumentation::willDestroyResource(this);

[dgozman, 2016/04/26 23:58:50]

Can we have a weak callback in WeakMember instead? Have you checked with Oilpan
team, do they plan to support it? It's unfortunate we have to do manual plumbing
using global collection in InspectorInstrumentation.cpp.

[hiroshige, 2016/04/28 08:06:33]

using global collection in InspectorInstrumentation.cpp.
Excuse me, could you explain a little more? WeakMember of which class?

[dgozman, 2016/04/28 15:17:26]

Nevermind. Go ahead with this patch, I will post a queestion to oilpan-dev.

+    willDestroyResourceInternal();
 }
 
 DEFINE_TRACE(Resource)
 {
     visitor->trace(m_loader);
     visitor->trace(m_cacheHandler);
 }
 
 void Resource::load(ResourceFetcher* fetcher)
 {
@@ skipping 819 matching lines @@
     case Resource::Media:
         return "Media";
     case Resource::Manifest:
         return "Manifest";
     }
     ASSERT_NOT_REACHED();
     return "Unknown";
 }
 
 } // namespace blink