Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1807313002: Move token_binding_nss.cc to net_non_nacl_sources. (Closed)

Created:
4 years, 9 months ago by Sergey Ulanov
Modified:
4 years, 9 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move token_binding_nss.cc to net_non_nacl_sources. Previoulsy both token_binding_nss.cc and token_binding_openssl.cc were compiled when compiling net for NaCl. This was causing linker warkings about duplicate symbols. BUG=595790 Committed: https://crrev.com/a7f891b06a0b1b278eaf241c78ce35e084b77a02 Cr-Commit-Position: refs/heads/master@{#381796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/net.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Sergey Ulanov
4 years, 9 months ago (2016-03-17 18:12:27 UTC) #2
davidben
Why are they both getting compiled? Shouldn't this line exclude it? https://code.google.com/p/chromium/codesearch#chromium/src/net/net_common.gypi&q=token_binding_nss&sq=package:chromium&type=cs&l=112
4 years, 9 months ago (2016-03-17 18:19:44 UTC) #3
Sergey Ulanov
On 2016/03/17 18:19:44, davidben wrote: > Why are they both getting compiled? Shouldn't this line ...
4 years, 9 months ago (2016-03-17 18:50:02 UTC) #4
davidben
On 2016/03/17 18:50:02, Sergey Ulanov wrote: > On 2016/03/17 18:19:44, davidben wrote: > > Why ...
4 years, 9 months ago (2016-03-17 19:21:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807313002/1
4 years, 9 months ago (2016-03-17 19:32:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 21:12:39 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 21:13:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7f891b06a0b1b278eaf241c78ce35e084b77a02
Cr-Commit-Position: refs/heads/master@{#381796}

Powered by Google App Engine
This is Rietveld 408576698