Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1807293005: MD History: Clear selection when changing to 'Open Tabs' (Closed)

Created:
4 years, 9 months ago by lshang
Modified:
4 years, 9 months ago
Reviewers:
tsergeant, calamity
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Clear selection when changing to 'Open Tabs' At present, when click 'Open Tabs' on the Material Design History page, the selected items on the history page don't get cleared and the toolbar remains light blue. This CL fixes this by unselecting all items before it switches to the other tab. BUG=595582 Committed: https://crrev.com/4642db726b0ada9a888a6469c6fbcde9fe14c84e Cr-Commit-Position: refs/heads/master@{#382238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/md_history/side_bar.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
lshang
PTAL thanks!
4 years, 9 months ago (2016-03-18 03:26:00 UTC) #3
calamity
lgtm.
4 years, 9 months ago (2016-03-18 03:38:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807293005/1
4 years, 9 months ago (2016-03-20 23:16:44 UTC) #6
lshang
On 2016/03/18 03:38:18, calamity wrote: > lgtm. Thanks!
4 years, 9 months ago (2016-03-20 23:16:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 00:08:24 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 00:09:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4642db726b0ada9a888a6469c6fbcde9fe14c84e
Cr-Commit-Position: refs/heads/master@{#382238}

Powered by Google App Engine
This is Rietveld 408576698