Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1807293004: Add runtime flag for <script type="module"> (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
haraken, sigbjornf
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add runtime flag for <script type="module"> Also exercise it in a very basic way in ScriptLoader (at the moment, <script type="module"> is treated the same as <script>). See intent-to-implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/uba6pMr-jec/tXdg6YYPBAAJ BUG=594639 Committed: https://crrev.com/7e4a661dd6f79f847d878be5651d8e7bd662a7f4 Cr-Commit-Position: refs/heads/master@{#382083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/HTMLScriptElement/module-script.html View 1 chunk +11 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/HTMLScriptElement/module-script-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
adamk
Greetings, I'm sending this CL out in such a basic state for two reasons: 1) ...
4 years, 9 months ago (2016-03-17 20:46:41 UTC) #2
haraken
LGTM On 2016/03/17 20:46:41, adamk wrote: > Greetings, > > I'm sending this CL out ...
4 years, 9 months ago (2016-03-17 23:23:02 UTC) #3
haraken
+Sigbjorn
4 years, 9 months ago (2016-03-17 23:23:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807293004/1
4 years, 9 months ago (2016-03-17 23:27:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/190890)
4 years, 9 months ago (2016-03-18 02:39:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807293004/1
4 years, 9 months ago (2016-03-18 17:19:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 20:55:58 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 20:57:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e4a661dd6f79f847d878be5651d8e7bd662a7f4
Cr-Commit-Position: refs/heads/master@{#382083}

Powered by Google App Engine
This is Rietveld 408576698