Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 1807293002: - Fix for issue 25950 (add registration of a thread exit callback) (Closed)

Created:
4 years, 9 months ago by siva
Modified:
4 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Fix for issue 25950 (add registration of a thread exit callback) - Moved some of the file and entropy callbacks to class Dart from class Isolate as they are not isolate specific. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f7d2b2e31ed8c3457abb2db8e97e2a6b1ee09587

Patch Set 1 #

Patch Set 2 : self-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -60 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/include/dart_api.h View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/lib/math.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/coverage.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/dart.h View 3 chunks +43 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +0 lines, -35 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/os_android.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/os_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/random.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/thread_pool.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 9 months ago (2016-03-17 17:34:50 UTC) #2
Cutch
lgtm
4 years, 9 months ago (2016-03-17 17:45:02 UTC) #3
siva
4 years, 9 months ago (2016-03-17 20:40:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f7d2b2e31ed8c3457abb2db8e97e2a6b1ee09587 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698