Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1807263004: Improve class-tree, class-view, and instance-view. (Closed)

Created:
4 years, 9 months ago by turnidge
Modified:
4 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve class-tree, class-view, and instance-view. class-tree - Make all the rows have the same height. - Hide synthetic mixin classes from the tree. - Show mixin information in a different way. - Show the total subclass count for each row if non-zero. class-view - Display supertype and mixin information instance-view - Display typeArguments, parameterizedClass, parameterIndex, targetType and bound information for Types. - Display a source for Types. - Provide an [eval] link for the runtimeType. isolate-view - Display the list of extension rpcs. Update service.md. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/22c37b9516104c3ca3b1fb988719b922460e6ac1

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -14 lines) Patch
M runtime/observatory/lib/src/app/view_model.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_tree.dart View 1 chunk +73 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 2 chunks +20 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.dart View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 3 chunks +60 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 4 chunks +20 lines, -2 lines 0 comments Download
M runtime/vm/object_service.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
turnidge
4 years, 9 months ago (2016-03-17 18:07:14 UTC) #3
Cutch
LGTM with some questions/suggestions. https://codereview.chromium.org/1807263004/diff/20001/runtime/observatory/lib/src/elements/instance_view.dart File runtime/observatory/lib/src/elements/instance_view.dart (right): https://codereview.chromium.org/1807263004/diff/20001/runtime/observatory/lib/src/elements/instance_view.dart#newcode20 runtime/observatory/lib/src/elements/instance_view.dart:20: // We load typeClass and ...
4 years, 9 months ago (2016-03-17 18:20:14 UTC) #4
turnidge
https://codereview.chromium.org/1807263004/diff/20001/runtime/observatory/lib/src/elements/instance_view.dart File runtime/observatory/lib/src/elements/instance_view.dart (right): https://codereview.chromium.org/1807263004/diff/20001/runtime/observatory/lib/src/elements/instance_view.dart#newcode20 runtime/observatory/lib/src/elements/instance_view.dart:20: // We load typeClass and typeArguments because we want ...
4 years, 9 months ago (2016-03-17 18:33:06 UTC) #5
turnidge
4 years, 9 months ago (2016-03-17 19:47:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
22c37b9516104c3ca3b1fb988719b922460e6ac1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698