src/promise.js - Issue 180723011: PromiseThen should ignore non-function parameters. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(948)

My Issues | Starred Open | Closed | All

Unified Diff: src/promise.js

Issue 180723011: PromiseThen should ignore non-function parameters. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | test/mjsunit/es6/promises.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/promise.js

diff --git a/src/promise.js b/src/promise.js

index 27890a7626b37d12af837e73627617d6a94da4f2..d387f279810bf61d674a6b0aa28e771d27911ede 100644

--- a/src/promise.js

+++ b/src/promise.js

@@ -202,9 +202,9 @@ function PromiseHandle(value, handler, deferred) {

function PromiseThen(onResolve, onReject) {

onResolve =

- IS_NULL_OR_UNDEFINED(onResolve) ? PromiseIdResolveHandler : onResolve;

+ IS_SPEC_FUNCTION(onResolve) ? onResolve : PromiseIdResolveHandler;

onReject =

- IS_NULL_OR_UNDEFINED(onReject) ? PromiseIdRejectHandler : onReject;

+ IS_SPEC_FUNCTION(onReject) ? onReject : PromiseIdRejectHandler;

var that = this;

var constructor = this.constructor;

return %_CallFunction(

« no previous file with comments | « no previous file | test/mjsunit/es6/promises.js » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698