Added tabs to the App Info dialog.

chrome/browser/ui/views/apps/app_info_dialog_views.h

-// Copyright 2014 The Chromium Authors. All rights reserved.

[Matt Giuca, 2014/03/04 01:36:57]

CL description:

The description seems to be out of date (describing the bigger patch you had
prepared before you split it up).

Can you remove the imgur links. This text is going to be permanently in the
Chrome SVN history. I think in general you should link to screenshots in review
discussion, not in the CL description. Please paste the relevant ones into a
comment on this CL, and delete from the description.

Say that you removed the heading from the dialog.

Don't need to say that it still requires the flag (describe what you changed,
not what you didn't change). Don't be vague ("kinda works with hosted apps");
say what is broken about it. Don't rely on screenshots.

[sashab, 2014/03/04 04:10:58]

Done
Done - I don't think any screenshots are needed for this one right now.
Done.
Done.
Removed this and put it in a separate bug report:
https://code.google.com/p/chromium/issues/detail?id=348857

-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_UI_VIEWS_APPS_APP_INFO_DIALOG_VIEWS_H_
-#define CHROME_BROWSER_UI_VIEWS_APPS_APP_INFO_DIALOG_VIEWS_H_
-
-#include "base/compiler_specific.h"
-#include "chrome/browser/shell_integration.h"
-#include "ui/message_center/views/bounded_scroll_view.h"
-#include "ui/views/controls/image_view.h"
-#include "ui/views/window/dialog_delegate.h"
-
-class Profile;
-
-namespace extensions {
-class Extension;
-}
-
-namespace views {
-class Label;
-}
-
-// A scrollable list of permissions for the given app.
-class PermissionsScrollView : public message_center::BoundedScrollView {
- public:
-  PermissionsScrollView(int min_height,
-                        int max_height,
-                        const extensions::Extension* app);
-
- private:
-  virtual ~PermissionsScrollView();
-
-  views::View* inner_scrollable_view;
-};
-
-// View the information about a particular chrome application.
-class AppInfoView : public views::DialogDelegateView,
-                    public base::SupportsWeakPtr<AppInfoView> {
- public:
-  AppInfoView(Profile* profile,
-              const extensions::Extension* app,
-              const base::Closure& close_callback);
-
- private:
-  virtual ~AppInfoView();
-
-  // Overridden from views::View:
-  virtual gfx::Size GetPreferredSize() OVERRIDE;
-
-  // Overridden from views::DialogDelegate:
-  virtual bool Cancel() OVERRIDE;
-  virtual base::string16 GetDialogButtonLabel(ui::DialogButton button)
-      const OVERRIDE;
-  virtual int GetDialogButtons() const OVERRIDE;
-  virtual bool IsDialogButtonEnabled(ui::DialogButton button) const OVERRIDE;
-
-  // Overridden from views::WidgetDelegate:
-  virtual ui::ModalType GetModalType() const OVERRIDE;
-  virtual base::string16 GetWindowTitle() const OVERRIDE;
-
-  // Called when the app's icon is loaded.
-  void OnAppImageLoaded(const gfx::Image& image);
-
-  // Profile in which the shortcuts will be created.
-  Profile* profile_;
-
-  // UI elements on the dialog.
-  views::Label* app_name_label;
-  views::Label* app_description_label;
-  views::Label* app_version_label;
-  views::ImageView* app_icon;
-  views::Label* permission_list_heading;
-  PermissionsScrollView* permissions_scroll_view;
-
-  const extensions::Extension* app_;
-  base::Closure close_callback_;
-
-  base::WeakPtrFactory<AppInfoView> weak_ptr_factory_;
-
-  DISALLOW_COPY_AND_ASSIGN(AppInfoView);
-};
-
-#endif  // CHROME_BROWSER_UI_VIEWS_APPS_APP_INFO_DIALOG_VIEWS_H_