Telemetry: Remove unnessessary 'benchmark' traces.

Telemetry: Remove unnessessary 'benchmark' traces.

We're moving towards 'benchmark' being only for traces that
are actually read by benchmarks, rather that part of
benchmarks. This changes several to 'input'. One is read by a
benchmark, so that is now 'input,benchmark'.

BUG=344765
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255318

[epenner, 2014-02-26 21:42:31]

Ptal.

[jdduke (slow), 2014-02-26 21:56:24]

lgtm, thanks!

https://codereview.chromium.org/180723007/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/synthetic_gesture_target_android.cc
(right):

https://codereview.chromium.org/180723007/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/synthetic_gesture_target_android.cc:36:
Java_TouchEventSynthesizer_setPointer(env, touch_event_synthesizer_.obj(),

Soon we may not have to use the TouchEventSynthesizer at all
(https://codereview.chromium.org/181833003/).  In fact, I'm not married to the
trace markers in this file at all if they haven't proved useful to the fastpath
trace scraping, i.e., if you want to get rid of them entirely go for it :)

[epennerAtGoogle, 2014-02-26 22:15:12]

https://codereview.chromium.org/180723007/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/synthetic_gesture_target_android.cc
(right):

https://codereview.chromium.org/180723007/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/synthetic_gesture_target_android.cc:36:
Java_TouchEventSynthesizer_setPointer(env, touch_event_synthesizer_.obj(),
On 2014/02/26 21:56:25, jdduke wrote:
> 
> Soon we may not have to use the TouchEventSynthesizer at all
> (https://codereview.chromium.org/181833003/).  In fact, I'm not married to the
> trace markers in this file at all if they haven't proved useful to the
fastpath
> trace scraping, i.e., if you want to get rid of them entirely go for it :)

Some of these did actually show as as having significant CPU time:

SyntheticGestureController::Flush	 0.5697 inclusive	 0.0407 exclusive	 1.02
calls
SyntheticGestureTarget::DispatchInputEventToPlatform	 0.5314 inclusive	 0.0354
exclusive	 1.02 calls
SyntheticGestureTargetAndroid::TouchInject	 0.4646 inclusive	 0.4619 exclusive	
1.02 calls

However for the low-noise benchmark on the bots, we want to disable all
'details'. We can still get these details locally though, so let's keep it for
now.

As a second pass, I want to disable enough 'details' such that they are all
meaningful and don't add noise to each-other, but that's for another patch.

[epenner, 2014-02-26 22:16:29]

The CQ bit was checked by epenner@chromium.org

[commit-bot: I haz the power, 2014-02-26 22:18:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/180723007/1

[jdduke (slow), 2014-02-26 22:21:44]

https://codereview.chromium.org/180723007/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/synthetic_gesture_target_android.cc
(right):

https://codereview.chromium.org/180723007/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/synthetic_gesture_target_android.cc:36:
Java_TouchEventSynthesizer_setPointer(env, touch_event_synthesizer_.obj(),
On 2014/02/26 22:15:12, epennerAtGoogle wrote:
> On 2014/02/26 21:56:25, jdduke wrote:
> > 
> > Soon we may not have to use the TouchEventSynthesizer at all
> > (https://codereview.chromium.org/181833003/).  In fact, I'm not married to
the
> > trace markers in this file at all if they haven't proved useful to the
> fastpath
> > trace scraping, i.e., if you want to get rid of them entirely go for it :)
> 
> Some of these did actually show as as having significant CPU time:
> 
> SyntheticGestureController::Flush	 0.5697 inclusive	 0.0407 exclusive	 1.02
> calls
> SyntheticGestureTarget::DispatchInputEventToPlatform	 0.5314 inclusive	 0.0354
> exclusive	 1.02 calls
> SyntheticGestureTargetAndroid::TouchInject	 0.4646 inclusive	 0.4619
exclusive	
> 1.02 calls
> 
> However for the low-noise benchmark on the bots, we want to disable all
> 'details'. We can still get these details locally though, so let's keep it for
> now.
> 
> As a second pass, I want to disable enough 'details' such that they are all
> meaningful and don't add noise to each-other, but that's for another patch.

Sounds good.

I guess the SyntheticGestureTargetAndroid::TouchInject exclusive time is such
because tracing doesn't support nested trace events when you go C++ -> Java ->
C++?   That is, TouchInject is what inserts the MotionEvent into the Java
pipeline, which in turn dispatches the event to native code for
processing/forwarding (and that portion of the native pipeline is definitely
traced).  In any case, that time looks about right for the complete touch
processing time per event.

[epennerAtGoogle, 2014-02-26 23:07:32]

> Sounds good.
> 
> I guess the SyntheticGestureTargetAndroid::TouchInject exclusive time is such
> because tracing doesn't support nested trace events when you go C++ -> Java ->
> C++?   That is, TouchInject is what inserts the MotionEvent into the Java
> pipeline, which in turn dispatches the event to native code for
> processing/forwarding (and that portion of the native pipeline is definitely
> traced).  In any case, that time looks about right for the complete touch
> processing time per event.

This is deceiving because I already only have 'benchmark' category enabled here.

[commit-bot: I haz the power, 2014-02-27 00:16:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-27 00:16:39]

Retried try job too often on win_rel for step(s) browser_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[epenner, 2014-02-27 01:01:59]

The CQ bit was checked by epenner@chromium.org

[commit-bot: I haz the power, 2014-02-27 01:02:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/180723007/1

[epenner, 2014-02-27 05:33:00]

The CQ bit was unchecked by epenner@chromium.org

[epenner, 2014-02-27 05:33:02]

The CQ bit was checked by epenner@chromium.org

[commit-bot: I haz the power, 2014-02-27 06:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-27 06:18:02]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[epenner, 2014-03-05 23:38:57]

The CQ bit was checked by epenner@chromium.org

[commit-bot: I haz the power, 2014-03-05 23:40:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/180723007/1

[commit-bot: I haz the power, 2014-03-05 23:41:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 23:41:04]

Failed to apply patch for
content/browser/renderer_host/input/synthetic_gesture_controller.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
content/browser/renderer_host/input/synthetic_gesture_controller.cc
  Hunk #1 FAILED at 30.
  Hunk #2 succeeded at 53 (offset 2 lines).
  Hunk #3 succeeded at 64 with fuzz 2 (offset 4 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
content/browser/renderer_host/input/synthetic_gesture_controller.cc.rej

Patch:       content/browser/renderer_host/input/synthetic_gesture_controller.cc
Index: content/browser/renderer_host/input/synthetic_gesture_controller.cc
diff --git a/content/browser/renderer_host/input/synthetic_gesture_controller.cc
b/content/browser/renderer_host/input/synthetic_gesture_controller.cc
index
9c28a7de59428cb866dad796698b15d7a0095ad7..5d7f1a0fd7c320ff3142fe8a2cef0ed2355b924e
100644
--- a/content/browser/renderer_host/input/synthetic_gesture_controller.cc
+++ b/content/browser/renderer_host/input/synthetic_gesture_controller.cc
@@ -30,7 +30,7 @@ void SyntheticGestureController::QueueSyntheticGesture(
 }
 
 void SyntheticGestureController::Flush(base::TimeTicks timestamp) {
-  TRACE_EVENT0("benchmark", "SyntheticGestureController::Flush");
+  TRACE_EVENT0("input", "SyntheticGestureController::Flush");
   if (pending_gesture_queue_.empty())
     return;
 
@@ -51,7 +51,8 @@ void SyntheticGestureController::Flush(base::TimeTicks
timestamp) {
 }
 
 void SyntheticGestureController::StartGesture(const SyntheticGesture& gesture)
{
-  TRACE_EVENT_ASYNC_BEGIN0("benchmark", "SyntheticGestureController::running",
+  TRACE_EVENT_ASYNC_BEGIN0("input,benchmark",
+                           "SyntheticGestureController::running",
                            &gesture);
   gesture_target_->SetNeedsFlush();
 }
@@ -59,7 +60,8 @@ void SyntheticGestureController::StartGesture(const
SyntheticGesture& gesture) {
 void SyntheticGestureController::StopGesture(
     const SyntheticGesture& gesture, SyntheticGesture::Result result) {
   DCHECK_NE(result, SyntheticGesture::GESTURE_RUNNING);
-  TRACE_EVENT_ASYNC_END0("benchmark", "SyntheticGestureController::running",
+  TRACE_EVENT_ASYNC_END0("input,benchmark",
+                         "SyntheticGestureController::running",
                          &gesture);
 
   gesture_target_->OnSyntheticGestureCompleted(result);

[epenner, 2014-03-06 01:43:47]

The CQ bit was checked by epenner@chromium.org

[commit-bot: I haz the power, 2014-03-06 01:44:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/180723007/20001

[commit-bot: I haz the power, 2014-03-06 02:59:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/180723007/20001

[commit-bot: I haz the power, 2014-03-06 03:20:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/180723007/20001

[commit-bot: I haz the power, 2014-03-06 12:59:34]

Change committed as 255318