Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: Source/core/xml/parser/XMLDocumentParser.cpp

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/XPathStep.cpp ('k') | Source/web/WebElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/parser/XMLDocumentParser.cpp
diff --git a/Source/core/xml/parser/XMLDocumentParser.cpp b/Source/core/xml/parser/XMLDocumentParser.cpp
index b3ae0c69d9829e1f8ff1106619fc623ca630484d..c2a06b2a0c3401e4498807e6c9e81e54e5b145b7 100644
--- a/Source/core/xml/parser/XMLDocumentParser.cpp
+++ b/Source/core/xml/parser/XMLDocumentParser.cpp
@@ -839,11 +839,11 @@ XMLDocumentParser::XMLDocumentParser(DocumentFragment* fragment, Element* parent
if (element->hasAttributes()) {
unsigned attributeCount = element->attributeCount();
for (unsigned i = 0; i < attributeCount; ++i) {
- const Attribute* attribute = element->attributeItem(i);
- if (attribute->localName() == xmlnsAtom)
- m_defaultNamespaceURI = attribute->value();
- else if (attribute->prefix() == xmlnsAtom)
- m_prefixToNamespaceMap.set(attribute->localName(), attribute->value());
+ const Attribute& attribute = element->attributeItem(i);
+ if (attribute.localName() == xmlnsAtom)
+ m_defaultNamespaceURI = attribute.value();
+ else if (attribute.prefix() == xmlnsAtom)
+ m_prefixToNamespaceMap.set(attribute.localName(), attribute.value());
}
}
}
« no previous file with comments | « Source/core/xml/XPathStep.cpp ('k') | Source/web/WebElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698