Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLEmbedElement.cpp ('k') | Source/core/inspector/DOMPatchSupport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLObjectElement.cpp
diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp
index c9732d4bdbd6eef0651abd62b6715425553396c0..b6d1317f27ecf15dafaa119a591285c0fd8192c9 100644
--- a/Source/core/html/HTMLObjectElement.cpp
+++ b/Source/core/html/HTMLObjectElement.cpp
@@ -185,11 +185,11 @@ void HTMLObjectElement::parametersForPlugin(Vector<String>& paramNames, Vector<S
if (hasAttributes()) {
unsigned attributeCount = this->attributeCount();
for (unsigned i = 0; i < attributeCount; ++i) {
- const Attribute* attribute = attributeItem(i);
- const AtomicString& name = attribute->name().localName();
+ const Attribute& attribute = attributeItem(i);
+ const AtomicString& name = attribute.name().localName();
if (!uniqueParamNames.contains(name.impl())) {
paramNames.append(name.string());
- paramValues.append(attribute->value().string());
+ paramValues.append(attribute.value().string());
}
}
}
« no previous file with comments | « Source/core/html/HTMLEmbedElement.cpp ('k') | Source/core/inspector/DOMPatchSupport.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698