Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: Source/core/editing/markup.cpp

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/MarkupAccumulator.cpp ('k') | Source/core/html/HTMLEmbedElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/markup.cpp
diff --git a/Source/core/editing/markup.cpp b/Source/core/editing/markup.cpp
index 1264f8c107ce2998132673fca90490775cd3adc5..9a6ec3e1846399acf4a8001652e39022abba0c55 100644
--- a/Source/core/editing/markup.cpp
+++ b/Source/core/editing/markup.cpp
@@ -101,9 +101,9 @@ static void completeURLs(DocumentFragment& fragment, const String& baseURL)
continue;
unsigned length = element->attributeCount();
for (unsigned i = 0; i < length; i++) {
- const Attribute* attribute = element->attributeItem(i);
- if (element->isURLAttribute(*attribute) && !attribute->value().isEmpty())
- changes.append(AttributeChange(element, attribute->name(), KURL(parsedBaseURL, attribute->value()).string()));
+ const Attribute& attribute = element->attributeItem(i);
+ if (element->isURLAttribute(attribute) && !attribute.value().isEmpty())
+ changes.append(AttributeChange(element, attribute.name(), KURL(parsedBaseURL, attribute.value()).string()));
}
}
@@ -280,11 +280,11 @@ void StyledMarkupAccumulator::appendElement(StringBuilder& out, Element& element
const bool shouldAnnotateOrForceInline = element.isHTMLElement() && (shouldAnnotate() || addDisplayInline);
const bool shouldOverrideStyleAttr = shouldAnnotateOrForceInline || shouldApplyWrappingStyle(element);
for (unsigned i = 0; i < length; ++i) {
- const Attribute* attribute = element.attributeItem(i);
+ const Attribute& attribute = element.attributeItem(i);
// We'll handle the style attribute separately, below.
- if (attribute->name() == styleAttr && shouldOverrideStyleAttr)
+ if (attribute.name() == styleAttr && shouldOverrideStyleAttr)
continue;
- appendAttribute(out, element, *attribute, 0);
+ appendAttribute(out, element, attribute, 0);
}
if (shouldOverrideStyleAttr) {
« no previous file with comments | « Source/core/editing/MarkupAccumulator.cpp ('k') | Source/core/html/HTMLEmbedElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698