Source/core/dom/NamedNodeMap.cpp - Issue 180723006: Have ElementData::attributeItem() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/NamedNodeMap.cpp

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/NamedNodeMap.cpp

diff --git a/Source/core/dom/NamedNodeMap.cpp b/Source/core/dom/NamedNodeMap.cpp

index f0627cfa7f34e6df1d13dba38aa80bdf4359a48e..00280faef7d06a731b95aca9e8c93ca41a256b05 100644

--- a/Source/core/dom/NamedNodeMap.cpp

+++ b/Source/core/dom/NamedNodeMap.cpp

@@ -100,7 +100,7 @@ PassRefPtr<Node> NamedNodeMap::item(unsigned index) const

{

if (index >= length())

return nullptr;

- return m_element->ensureAttr(m_element->attributeItem(index)->name());

+ return m_element->ensureAttr(m_element->attributeItem(index).name());

}

size_t NamedNodeMap::length() const

« no previous file with comments | « Source/core/dom/ElementData.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »