Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: Source/core/dom/Element.h

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/DatasetDOMStringMap.cpp ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2013 Appl e Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2013 Appl e Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 // Call this to get the value of the id attribute for style resolution purpo ses. 151 // Call this to get the value of the id attribute for style resolution purpo ses.
152 // The value will already be lowercased if the document is in compatibility mode, 152 // The value will already be lowercased if the document is in compatibility mode,
153 // so this function is not suitable for non-style uses. 153 // so this function is not suitable for non-style uses.
154 const AtomicString& idForStyleResolution() const; 154 const AtomicString& idForStyleResolution() const;
155 155
156 // Internal methods that assume the existence of attribute storage, one shou ld use hasAttributes() 156 // Internal methods that assume the existence of attribute storage, one shou ld use hasAttributes()
157 // before calling them. This is not a trivial getter and its return value sh ould be cached for 157 // before calling them. This is not a trivial getter and its return value sh ould be cached for
158 // performance. 158 // performance.
159 size_t attributeCount() const; 159 size_t attributeCount() const;
160 const Attribute* attributeItem(unsigned index) const; 160 const Attribute& attributeItem(unsigned index) const;
161 const Attribute* getAttributeItem(const QualifiedName&) const; 161 const Attribute* getAttributeItem(const QualifiedName&) const;
162 size_t getAttributeItemIndex(const QualifiedName& name) const { return eleme ntData()->getAttributeItemIndex(name); } 162 size_t getAttributeItemIndex(const QualifiedName& name) const { return eleme ntData()->getAttributeItemIndex(name); }
163 size_t getAttributeItemIndex(const AtomicString& name, bool shouldIgnoreAttr ibuteCase) const { return elementData()->getAttributeItemIndex(name, shouldIgnor eAttributeCase); } 163 size_t getAttributeItemIndex(const AtomicString& name, bool shouldIgnoreAttr ibuteCase) const { return elementData()->getAttributeItemIndex(name, shouldIgnor eAttributeCase); }
164 164
165 void scrollIntoView(bool alignToTop = true); 165 void scrollIntoView(bool alignToTop = true);
166 void scrollIntoViewIfNeeded(bool centerIfNeeded = true); 166 void scrollIntoViewIfNeeded(bool centerIfNeeded = true);
167 167
168 void scrollByLines(int lines); 168 void scrollByLines(int lines);
169 void scrollByPages(int pages); 169 void scrollByPages(int pages);
170 170
(...skipping 589 matching lines...) Expand 10 before | Expand all | Expand 10 after
760 ASSERT(elementData()); 760 ASSERT(elementData());
761 return elementData()->classNames(); 761 return elementData()->classNames();
762 } 762 }
763 763
764 inline size_t Element::attributeCount() const 764 inline size_t Element::attributeCount() const
765 { 765 {
766 ASSERT(elementData()); 766 ASSERT(elementData());
767 return elementData()->length(); 767 return elementData()->length();
768 } 768 }
769 769
770 inline const Attribute* Element::attributeItem(unsigned index) const 770 inline const Attribute& Element::attributeItem(unsigned index) const
771 { 771 {
772 ASSERT(elementData()); 772 ASSERT(elementData());
773 return elementData()->attributeItem(index); 773 return elementData()->attributeItem(index);
774 } 774 }
775 775
776 inline const Attribute* Element::getAttributeItem(const QualifiedName& name) con st 776 inline const Attribute* Element::getAttributeItem(const QualifiedName& name) con st
777 { 777 {
778 ASSERT(elementData()); 778 ASSERT(elementData());
779 return elementData()->getAttributeItem(name); 779 return elementData()->getAttributeItem(name);
780 } 780 }
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
859 } 859 }
860 860
861 inline bool isShadowHost(const Element* element) 861 inline bool isShadowHost(const Element* element)
862 { 862 {
863 return element && element->shadow(); 863 return element && element->shadow();
864 } 864 }
865 865
866 } // namespace 866 } // namespace
867 867
868 #endif 868 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/DatasetDOMStringMap.cpp ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698