Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: Source/core/css/SelectorChecker.h

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/css/SelectorChecker.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 const AtomicString& namespaceURI = tagQName.namespaceURI(); 164 const AtomicString& namespaceURI = tagQName.namespaceURI();
165 return namespaceURI == starAtom || namespaceURI == element.namespaceURI(); 165 return namespaceURI == starAtom || namespaceURI == element.namespaceURI();
166 } 166 }
167 167
168 inline bool SelectorChecker::checkExactAttribute(const Element& element, const Q ualifiedName& selectorAttributeName, const StringImpl* value) 168 inline bool SelectorChecker::checkExactAttribute(const Element& element, const Q ualifiedName& selectorAttributeName, const StringImpl* value)
169 { 169 {
170 if (!element.hasAttributesWithoutUpdate()) 170 if (!element.hasAttributesWithoutUpdate())
171 return false; 171 return false;
172 unsigned size = element.attributeCount(); 172 unsigned size = element.attributeCount();
173 for (unsigned i = 0; i < size; ++i) { 173 for (unsigned i = 0; i < size; ++i) {
174 const Attribute* attribute = element.attributeItem(i); 174 const Attribute& attribute = element.attributeItem(i);
175 if (attribute->matches(selectorAttributeName) && (!value || attribute->v alue().impl() == value)) 175 if (attribute.matches(selectorAttributeName) && (!value || attribute.val ue().impl() == value))
176 return true; 176 return true;
177 } 177 }
178 return false; 178 return false;
179 } 179 }
180 180
181 inline bool SelectorChecker::isHostInItsShadowTree(const Element& element, Behav iorAtBoundary behaviorAtBoundary, const ContainerNode* scope) 181 inline bool SelectorChecker::isHostInItsShadowTree(const Element& element, Behav iorAtBoundary behaviorAtBoundary, const ContainerNode* scope)
182 { 182 {
183 return (behaviorAtBoundary & (ScopeIsShadowHost | TreatShadowHostAsNormalSco pe)) == ScopeIsShadowHost && scope == element; 183 return (behaviorAtBoundary & (ScopeIsShadowHost | TreatShadowHostAsNormalSco pe)) == ScopeIsShadowHost && scope == element;
184 } 184 }
185 185
186 } 186 }
187 187
188 #endif 188 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/SelectorChecker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698