Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 180723005: [Android] Add event_unittests to the default cq/try runs (Closed)

Created:
6 years, 10 months ago by jdduke (slow)
Modified:
6 years, 9 months ago
Reviewers:
bulach, Yaron
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, klundberg, navabi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Add events_unittests to the default cq/try runs These tests will soon cover a core portion of Android's touch/gesture pipeline, and should be run by default accordingly. BUG=332418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253790

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M build/all.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jdduke (slow)
bulach@: PTAL. I don't think we should be concerned about additional load here as these ...
6 years, 10 months ago (2014-02-26 18:32:06 UTC) #1
jdduke (slow)
On 2014/02/26 18:32:06, jdduke wrote: > bulach@: PTAL. I don't think we should be concerned ...
6 years, 10 months ago (2014-02-26 18:38:51 UTC) #2
jdduke (slow)
yfriedman@: Hmm, looks like I missed bulach@, would you mind taking a look? As noted ...
6 years, 10 months ago (2014-02-26 23:29:56 UTC) #3
Yaron
lgtm looks like you need to rebase tho
6 years, 10 months ago (2014-02-27 00:43:53 UTC) #4
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-27 01:01:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/180723005/20001
6 years, 10 months ago (2014-02-27 01:03:30 UTC) #6
commit-bot: I haz the power
Change committed as 253790
6 years, 9 months ago (2014-02-27 13:49:47 UTC) #7
bulach
6 years, 9 months ago (2014-02-27 16:02:24 UTC) #8
Message was sent while issue was closed.
late lgtm, thanks!

btw, for anything that influences bots / CQ / trybots, please, make sure you
keep navabi@ / klundberg@ in the loop, so they chime in for any potential
capacity issues.

Powered by Google App Engine
This is Rietveld 408576698