Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 180723003: Land Recent QUIC Changes. (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Visibility:
Public.

Description

Land Recent QUIC Changes. These LOG(INFO)s claimed 8-9% of time under a load test. Reduce logspam in QuicUnackedPacketMap. Merge internal change: 61895796 https://codereview.chromium.org/179773007/ QUIC WINDOW_UPDATE and BLOCKED frames instigate ACKs. Merge internal change: 61894847 https://codereview.chromium.org/180013004/ Avoiding quic double-close bugs by detecting it at the connection. Merge internal change: 61890466 https://codereview.chromium.org/180793003/ BLOCKED frames not being cleared. These are not yet used. (minor) Clear last BLOCKED frames in QuicConnection Merge internal change: 61875848 https://codereview.chromium.org/180793002/ QUIC - minor cleanup while merging internal change. Merge internal change: 61850595 https://codereview.chromium.org/177073016/ Create QUIC_VERSION_16 which breaks the sent_info field out of the ACK frame into a new STOP_WAITING frame. Does not change when this information is sent. That will happen in a follow-up CL. Send STOP_WAITING_FRAME for QUIC version 16 and above with Ack frame. Added logging for WINDOW_UPDATE and BLOCKED frames. Merge internal change: 61838258 https://codereview.chromium.org/180383004/ QUIC test refactor to move tests from the QuicSentPacketManagerTest to the new TcpLossAlgorithmTest. Merge internal change: 61837708 https://codereview.chromium.org/177203008/ Ctrl-F for "packet XY" in debug logs now matches sent packets "Sending packet XY", and received packets "Got packet XY". (minor) Improve QUIC packet sent debug log message Merge internal change: 61836667 https://codereview.chromium.org/177003007/ Auotmated rollback of internal changelist 57996291. *** Reason for rollback *** Now that clients no longer suggests 100 by default, it would be nice to experiment with allowing the client to suggest larger CWNDs. *** Original change description *** Temporarily change the maximum server initial congestion window to 10 from 100, because many existing Chrome clients are still negotiating 100, causing visible performance issues, particularly for YouTube rebuffers. *** Merge internal change: 61825277 https://codereview.chromium.org/178853003/ Refactor to create a new LossDetectionInterface used by the QuicSentPacketManager. Merge internal change: 61813052 https://codereview.chromium.org/178453005/ Preparation for only writing a fraction of the iov due to flow control blocking in ReliableQuicStream::WritevData. Add max_bytes argument to QuicSession::WritevData Merge internal change: 61810929 https://codereview.chromium.org/177203006/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253647

Patch Set 1 #

Patch Set 2 : Fix unintialized memory error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1805 lines, -577 lines) Patch
M net/base/net_log_event_type_list.h View 1 chunk +33 lines, -0 lines 0 comments Download
M net/net.gyp View 3 chunks +5 lines, -0 lines 0 comments Download
A net/quic/congestion_control/loss_detection_interface.h View 1 chunk +35 lines, -0 lines 0 comments Download
A net/quic/congestion_control/loss_detection_interface.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A net/quic/congestion_control/tcp_loss_algorithm.h View 1 chunk +36 lines, -0 lines 0 comments Download
A net/quic/congestion_control/tcp_loss_algorithm.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A net/quic/congestion_control/tcp_loss_algorithm_test.cc View 1 chunk +147 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 7 chunks +16 lines, -2 lines 0 comments Download
M net/quic/quic_connection.cc View 17 chunks +91 lines, -31 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 3 chunks +53 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 131 chunks +382 lines, -171 lines 0 comments Download
M net/quic/quic_framer.h View 4 chunks +13 lines, -5 lines 0 comments Download
M net/quic/quic_framer.cc View 11 chunks +86 lines, -31 lines 0 comments Download
M net/quic/quic_framer_test.cc View 17 chunks +590 lines, -27 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M net/quic/quic_packet_generator.h View 3 chunks +11 lines, -1 line 0 comments Download
M net/quic/quic_packet_generator.cc View 5 chunks +27 lines, -7 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 13 chunks +23 lines, -8 lines 0 comments Download
M net/quic/quic_protocol.h View 10 chunks +17 lines, -11 lines 0 comments Download
M net/quic/quic_protocol.cc View 7 chunks +18 lines, -3 lines 0 comments Download
M net/quic/quic_received_packet_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 4 chunks +7 lines, -5 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 8 chunks +13 lines, -46 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 3 chunks +6 lines, -162 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 6 chunks +9 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 4 chunks +16 lines, -1 line 0 comments Download
M net/quic/test_tools/simple_quic_framer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 6 chunks +19 lines, -4 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 6 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
6 years, 10 months ago (2014-02-26 01:29:59 UTC) #1
Ryan Hamilton
lgtm
6 years, 10 months ago (2014-02-26 16:30:27 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 10 months ago (2014-02-26 17:51:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/180723003/20001
6 years, 10 months ago (2014-02-26 17:54:09 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 00:09:05 UTC) #5
Message was sent while issue was closed.
Change committed as 253647

Powered by Google App Engine
This is Rietveld 408576698