Issue 180723002: Incorrect SSLError attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180723002: Incorrect SSLError attribute. (Closed)

Created:
6 years, 10 months ago by Sergey Berezin

Modified:
6 years, 10 months ago

Reviewers:
agable, ghost stip (do not use)

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

Incorrect SSLError attribute. ssl.SSLError does NOT have 'reason' attribute. Use str() to get a reliable string. Fixed the silly bug in another CL: https://codereview.chromium.org/180273003/ The ssl.SSLError does NOT have attribute 'reason', and must use the generic 'strerror' instead. This is what happens when I submit a CL too fast... BUG=346845 R=stip@chromium.org,maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=253317