Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4143)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Issue 1807223003: [Media Router WebUI] Clear pending route creation properties on error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per mfoltz@'s comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/media_router/media_router_data.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
index b99b88abf91a9c75c98b972e38c17b605362e67f..d0126c7dcc5ff5389abd01e23d8805880d10ed10 100644
--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
@@ -1195,7 +1195,9 @@ Polymer({
},
/**
- * Updates |currentView_| if there is a new blocking issue.
+ * Updates |currentView_| if there is a new blocking issue. Clears any
+ * pending route creation properties if the issue corresponds with
+ * |pendingCreatedRouteId_|.
*
* @param {?media_router.Issue} issue The new issue.
* @private
@@ -1205,6 +1207,11 @@ Polymer({
this.currentView_ = media_router.MediaRouterView.ISSUE;
else
this.updateElementPositioning_();
+
+ if (!!this.pendingCreatedRouteId_ && !!issue &&
+ issue.routeId == this.pendingCreatedRouteId_) {
+ this.resetRouteCreationProperties_(false);
+ }
},
/**
« no previous file with comments | « no previous file | chrome/browser/resources/media_router/media_router_data.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698