Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: chrome/browser/resources/media_router/media_router_data.js

Issue 1807223003: [Media Router WebUI] Clear pending route creation properties on error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per mfoltz@'s comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Any strings used here will already be localized. Values such as 5 // Any strings used here will already be localized. Values such as
6 // CastMode.type or IDs will be defined elsewhere and determined later. 6 // CastMode.type or IDs will be defined elsewhere and determined later.
7 7
8 cr.exportPath('media_router'); 8 cr.exportPath('media_router');
9 9
10 /** 10 /**
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 */ 113 */
114 var AUTO_CAST_MODE = new CastMode(media_router.CastModeType.AUTO, 114 var AUTO_CAST_MODE = new CastMode(media_router.CastModeType.AUTO,
115 loadTimeData.getString('autoCastMode'), null); 115 loadTimeData.getString('autoCastMode'), null);
116 116
117 /** 117 /**
118 * @param {string} id The ID of this issue. 118 * @param {string} id The ID of this issue.
119 * @param {string} title The issue title. 119 * @param {string} title The issue title.
120 * @param {string} message The issue message. 120 * @param {string} message The issue message.
121 * @param {number} defaultActionType The type of default action. 121 * @param {number} defaultActionType The type of default action.
122 * @param {?number} secondaryActionType The type of optional action. 122 * @param {?number} secondaryActionType The type of optional action.
123 * @param {?string} mediaRouteId The route ID to which this issue 123 * @param {?string} routeId The route ID to which this issue
124 * pertains. If not set, this is a global issue. 124 * pertains. If not set, this is a global issue.
125 * @param {boolean} isBlocking True if this issue blocks other UI. 125 * @param {boolean} isBlocking True if this issue blocks other UI.
126 * @param {?number} helpPageId The numeric help center ID. 126 * @param {?number} helpPageId The numeric help center ID.
127 * @constructor 127 * @constructor
128 * @struct 128 * @struct
129 */ 129 */
130 var Issue = function(id, title, message, defaultActionType, 130 var Issue = function(id, title, message, defaultActionType,
131 secondaryActionType, mediaRouteId, isBlocking, 131 secondaryActionType, routeId, isBlocking,
132 helpPageId) { 132 helpPageId) {
133 /** @type {string} */ 133 /** @type {string} */
134 this.id = id; 134 this.id = id;
135 135
136 /** @type {string} */ 136 /** @type {string} */
137 this.title = title; 137 this.title = title;
138 138
139 /** @type {string} */ 139 /** @type {string} */
140 this.message = message; 140 this.message = message;
141 141
142 /** @type {number} */ 142 /** @type {number} */
143 this.defaultActionType = defaultActionType; 143 this.defaultActionType = defaultActionType;
144 144
145 /** @type {?number} */ 145 /** @type {?number} */
146 this.secondaryActionType = secondaryActionType; 146 this.secondaryActionType = secondaryActionType;
147 147
148 /** @type {?string} */ 148 /** @type {?string} */
149 this.mediaRouteId = mediaRouteId; 149 this.routeId = routeId;
150 150
151 /** @type {boolean} */ 151 /** @type {boolean} */
152 this.isBlocking = isBlocking; 152 this.isBlocking = isBlocking;
153 153
154 /** @type {?number} */ 154 /** @type {?number} */
155 this.helpPageId = helpPageId; 155 this.helpPageId = helpPageId;
156 }; 156 };
157 157
158 158
159 /** 159 /**
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 246
247 return { 247 return {
248 AUTO_CAST_MODE: AUTO_CAST_MODE, 248 AUTO_CAST_MODE: AUTO_CAST_MODE,
249 CastMode: CastMode, 249 CastMode: CastMode,
250 Issue: Issue, 250 Issue: Issue,
251 Route: Route, 251 Route: Route,
252 Sink: Sink, 252 Sink: Sink,
253 TabInfo: TabInfo, 253 TabInfo: TabInfo,
254 }; 254 };
255 }); 255 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698