Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 1807193003: Show v8.parseOnBackground in DevTools Timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
index 6e70d88d6ddf833e282990a13c644517cae0f4e9..86d1974e3b63516be4dbc4ad9de9d4289c5a35ee 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
@@ -556,7 +556,7 @@ WebInspector.linkifyDocumentationURLAsNode = function(article, title)
WebInspector.linkifyResourceAsNode = function(url, lineNumber, columnNumber, classes, tooltipText, urlDisplayName)
{
var linkText = urlDisplayName ? urlDisplayName : url ? WebInspector.displayNameForURL(url) : WebInspector.UIString("(program)");
- if (typeof lineNumber === "number")
+ if (typeof lineNumber === "number" && !isNaN(lineNumber))
caseq 2016/03/25 02:00:59 this looks quite unfortunate, how do we get a NaN
horo 2016/03/25 04:51:45 Done. linkifyLocation() calls linkifier.linkifySc
linkText += ":" + (lineNumber + 1);
var anchor = WebInspector.linkifyURLAsNode(url, linkText, classes, false, tooltipText);
anchor.lineNumber = lineNumber;

Powered by Google App Engine
This is Rietveld 408576698