Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 1807193003: Show v8.parseOnBackground in DevTools Timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
index a69268d31b60d690496e6cf1554a9937562246cb..a2e54143ae22f050ef347280553d35bc88f881e3 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -90,6 +90,7 @@ WebInspector.TimelineUIUtils._initEventStyles = function()
eventStyles[recordTypes.XHRLoad] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("XHR Load"), categories["scripting"]);
eventStyles[recordTypes.CompileScript] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Compile Script"), categories["scripting"]);
eventStyles[recordTypes.EvaluateScript] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Evaluate Script"), categories["scripting"]);
+ eventStyles[recordTypes.ParseScriptOnBackground] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Parse Script"), categories["scripting"]);
eventStyles[recordTypes.MarkLoad] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Load event"), categories["scripting"], true);
eventStyles[recordTypes.MarkDOMContent] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("DOMContentLoaded event"), categories["scripting"], true);
eventStyles[recordTypes.MarkFirstPaint] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("First paint"), categories["painting"], true);
@@ -391,13 +392,14 @@ WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent = function(event, tar
case recordType.EvaluateScript:
var url = eventData["url"];
if (url)
- detailsText = detailsText = WebInspector.displayNameForURL(url) + ":" + eventData["lineNumber"];
+ detailsText = WebInspector.displayNameForURL(url) + ":" + eventData["lineNumber"];
break;
+ case recordType.ParseScriptOnBackground:
case recordType.XHRReadyStateChange:
case recordType.XHRLoad:
var url = eventData["url"];
if (url)
- detailsText = detailsText = WebInspector.displayNameForURL(url);
+ detailsText = WebInspector.displayNameForURL(url);
break;
case recordType.WebSocketCreate:
@@ -534,6 +536,11 @@ WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, tar
if (url)
details = linkifyLocation("", url, eventData["lineNumber"], 0);
break;
+ case recordType.ParseScriptOnBackground:
alph 2016/03/19 03:14:38 nit: you can merge it with the previous cases.
horo 2016/03/23 07:06:05 Done.
+ var url = eventData["url"];
+ if (url)
+ details = linkifyLocation("", url, 0, 0);
caseq 2016/03/18 23:36:04 nit: drop line/column numbers, these are default p
horo 2016/03/23 07:06:05 Fixed WebInspector.linkifyResourceAsNode().
+ break;
default:
if (event.hasCategory(WebInspector.TimelineModel.Category.Console))
detailsText = null;
@@ -2133,4 +2140,4 @@ WebInspector.TimelineUIUtils.PerformanceLineDecorator.prototype = {
textEditor.setGutterDecoration(decoration.line(), decoration.type(), element);
}
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698