Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1807173002: [elements] Fix sorting dictionary element keys (Closed)

Created:
4 years, 9 months ago by Camillo Bruni
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements] Fix sorting dictionary element keys Using std::sort on a FixedArray with HeapNumbers is not very GC friendly. Adding a separate step to properly record possible HeapNumbers. BUG=chromium:594954 LOG=N Committed: https://crrev.com/cda9a79931c34cec28f8ac1506c98edcee683908 Cr-Commit-Position: refs/heads/master@{#34888}

Patch Set 1 #

Patch Set 2 : specializing GetIterationLength for DICTIONARY_ELEMENTS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M src/elements.cc View 1 4 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Camillo Bruni
PTAL
4 years, 9 months ago (2016-03-17 12:15:14 UTC) #3
Toon Verwaest
Please specialize GetIterationLength to fast or slow elements kind to avoid extra overhead for FastElements ...
4 years, 9 months ago (2016-03-17 15:06:01 UTC) #4
Camillo Bruni
PTAL again
4 years, 9 months ago (2016-03-17 19:42:42 UTC) #5
Toon Verwaest
awesome, thanks. LGTM
4 years, 9 months ago (2016-03-18 10:16:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807173002/20001
4 years, 9 months ago (2016-03-18 11:37:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12578)
4 years, 9 months ago (2016-03-18 11:43:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807173002/20001
4 years, 9 months ago (2016-03-18 11:56:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 12:42:58 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 12:44:23 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cda9a79931c34cec28f8ac1506c98edcee683908
Cr-Commit-Position: refs/heads/master@{#34888}

Powered by Google App Engine
This is Rietveld 408576698