Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1807063002: Remove GetTLSUniqueChannelBinding. (Closed)

Created:
4 years, 9 months ago by davidben
Modified:
4 years, 9 months ago
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GetTLSUniqueChannelBinding. This was never implemented outside NSS sockets and things aren't using it anywhere. Token Binding is now using key exporters, so we can remove this. BUG=none Committed: https://crrev.com/9f20780fbb2ee55ff3852a4a81857a239992dd5c Cr-Commit-Position: refs/heads/master@{#381626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
M chrome/browser/extensions/api/socket/tls_socket_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/socket_test_util.h View 2 chunks +0 lines, -4 lines 0 comments Download
M net/socket/socket_test_util.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/socket/ssl_server_socket_nss.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M net/socket/ssl_server_socket_openssl.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/socket/ssl_socket.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
davidben
mek for chrome/browser/extensions/api/socket/tls_socket_unittest.cc
4 years, 9 months ago (2016-03-16 22:33:13 UTC) #2
nharper
lgtm
4 years, 9 months ago (2016-03-16 22:35:32 UTC) #3
Marijn Kruisselbrink
lgtm
4 years, 9 months ago (2016-03-16 22:42:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807063002/1
4 years, 9 months ago (2016-03-16 22:43:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 01:17:00 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 01:19:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f20780fbb2ee55ff3852a4a81857a239992dd5c
Cr-Commit-Position: refs/heads/master@{#381626}

Powered by Google App Engine
This is Rietveld 408576698