Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1807053002: Speculative crash fix for media::RendererImpl::GetMediaTime (Closed)

Created:
4 years, 9 months ago by hubbe
Modified:
4 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative crash fix for media::RendererImpl::GetMediaTime It seems that when the SeekDone comes from the remote side, we crash if there is no pipeline. When we're remoting, we should probably get the pause_time_ from the remote side, so let's avoid the crash by doing that. BUG=586225 Committed: https://crrev.com/5a2dec021242f84d0ec662e272bb1e15bdb2cf25 Cr-Commit-Position: refs/heads/master@{#381624}

Patch Set 1 #

Patch Set 2 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M media/blink/webmediaplayer_impl.cc View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
hubbe
4 years, 9 months ago (2016-03-16 22:26:43 UTC) #2
DaleCurtis
+sandersd, I believe this is the expectation for WMPA cast, so this lgtm
4 years, 9 months ago (2016-03-16 22:33:39 UTC) #4
sandersd (OOO until July 31)
lgtm
4 years, 9 months ago (2016-03-16 22:37:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807053002/1
4 years, 9 months ago (2016-03-16 22:39:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/36954)
4 years, 9 months ago (2016-03-16 22:53:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807053002/20001
4 years, 9 months ago (2016-03-16 23:50:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 01:14:31 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 01:15:42 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a2dec021242f84d0ec662e272bb1e15bdb2cf25
Cr-Commit-Position: refs/heads/master@{#381624}

Powered by Google App Engine
This is Rietveld 408576698