third_party/WebKit/Source/core/dom/Fullscreen.cpp - Issue 1807033003: Rewrite how RemoteFrameOwners retain life.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 1807033003: Rewrite how RemoteFrameOwners retain life. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp

diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp

index b2977f4ca9ef268043083d4ebc3a668d67cfd40c..07d7ca20a71871b99dfa0c71f6fd9142a103dc62 100644

--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp

+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp

@@ -59,7 +59,7 @@ static bool fullscreenIsAllowedForAllOwners(const Document& document)

// TODO(alexmos): The allowfullscreen attribute will need to be

// replicated for this to work with OOPIFs. For now, deny fullscreen

// access inside OOPIFs until https://crbug.com/550497 is fixed.

- if (!frame->owner()->isLocal())

+ if (frame->owner()->isRemote())

return false;

HTMLFrameOwnerElement* owner = toHTMLFrameOwnerElement(frame->owner());