Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: third_party/WebKit/Source/web/RemoteBridgeFrameOwner.h

Issue 1807033003: Rewrite how RemoteFrameOwners retain life. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/RemoteBridgeFrameOwner.h
diff --git a/third_party/WebKit/Source/web/RemoteBridgeFrameOwner.h b/third_party/WebKit/Source/web/RemoteBridgeFrameOwner.h
deleted file mode 100644
index b3300a6213271c8db27f64d54617c20fa6704f22..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/web/RemoteBridgeFrameOwner.h
+++ /dev/null
@@ -1,60 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be found
-// in the LICENSE file.
-
-#ifndef RemoteBridgeFrameOwner_h
-#define RemoteBridgeFrameOwner_h
-
-#include "core/frame/FrameOwner.h"
-#include "platform/scroll/ScrollTypes.h"
-#include "public/web/WebFrameOwnerProperties.h"
-
-namespace blink {
-
-// Helper class to bridge communication for a frame with a remote parent.
-// Currently, it serves two purposes:
-// 1. Allows the local frame's loader to retrieve sandbox flags associated with
-// its owner element in another process.
-// 2. Trigger a load event on its owner element once it finishes a load.
-class RemoteBridgeFrameOwner final : public NoBaseWillBeGarbageCollectedFinalized<RemoteBridgeFrameOwner>, public FrameOwner {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RemoteBridgeFrameOwner);
-public:
- static PassOwnPtrWillBeRawPtr<RemoteBridgeFrameOwner> create(SandboxFlags flags, const WebFrameOwnerProperties& frameOwnerProperties)
- {
- return adoptPtrWillBeNoop(new RemoteBridgeFrameOwner(flags, frameOwnerProperties));
- }
-
- // FrameOwner overrides:
- bool isLocal() const override { return false; }
- void setContentFrame(Frame&) override;
- void clearContentFrame() override;
- SandboxFlags getSandboxFlags() const override { return m_sandboxFlags; }
- void setSandboxFlags(SandboxFlags flags) { m_sandboxFlags = flags; }
- void dispatchLoad() override;
- // TODO(dcheng): Implement.
- void renderFallbackContent() override { }
- ScrollbarMode scrollingMode() const override { return m_scrolling; }
- int marginWidth() const override { return m_marginWidth; }
- int marginHeight() const override { return m_marginHeight; }
-
- void setScrollingMode(WebFrameOwnerProperties::ScrollingMode);
- void setMarginWidth(int marginWidth) { m_marginWidth = marginWidth; }
- void setMarginHeight(int marginHeight) { m_marginHeight = marginHeight; }
-
- DECLARE_VIRTUAL_TRACE();
-
-private:
- RemoteBridgeFrameOwner(SandboxFlags, const WebFrameOwnerProperties&);
-
- RawPtrWillBeMember<Frame> m_frame;
- SandboxFlags m_sandboxFlags;
- ScrollbarMode m_scrolling;
- int m_marginWidth;
- int m_marginHeight;
-};
-
-DEFINE_TYPE_CASTS(RemoteBridgeFrameOwner, FrameOwner, owner, !owner->isLocal(), !owner.isLocal());
-
-} // namespace blink
-
-#endif // RemoteBridgeFrameOwner_h

Powered by Google App Engine
This is Rietveld 408576698