Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: net/quic/quic_connection_test.cc

Issue 1807033002: Don't copy the QuicAckFrame into the QuicPacketGenerator. Protected by quic_dont_copy_acks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116794514
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index 38ec1aa54bf1445cf91da8df7911594828927ec8..7b8314a18d3bb42f6621628a464a5f3c651dbc2e 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -699,7 +699,13 @@ class QuicConnectionTest : public ::testing::TestWithParam<TestParams> {
QuicVersion version() { return GetParam().version; }
QuicAckFrame* outgoing_ack() {
- QuicConnectionPeer::PopulateAckFrame(&connection_, &ack_);
+ if (FLAGS_quic_dont_copy_acks) {
+ QuicFrame ack_frame =
+ QuicConnectionPeer::GetUpdatedAckFrame(&connection_);
+ ack_ = *ack_frame.ack_frame;
+ } else {
+ QuicConnectionPeer::PopulateAckFrame(&connection_, &ack_);
+ }
return &ack_;
}
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698