Issue 180703004: Merged r19591, r19599 into 3.23 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180703004: Merged r19591, r19599 into 3.23 branch. (Closed)

Created:
6 years, 9 months ago by danno

Modified:
6 years, 9 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.23

Visibility:
Public.

More Reviews

Description

Merged r19591, r19599 into 3.23 branch. HAllocate should never generate allocation code if the requested size does not fit into page. Regression test included. Fix representation generalization for doubles. BUG=347543 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19630

Patch Set 1 #

Patch Set 2 : Add missing constant #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -23 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/property-details.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/spaces.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-347909.js	View		1 chunk	+10 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

6 years, 9 months ago (2014-02-28 20:18:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19630 (tree was closed).

Expand Messages | Collapse Messages