Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 1807003002: [crankshaft] Specialize JS runtime calls to the native context. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Specialize JS runtime calls to the native context. Since Crankshaft specializes to the native context anyways, we don't need the indirection of loading from the native context and calling the JS runtime function indirectly, but we can just specialize to the JS runtime function from the native context and emit a direct (constant) function call. BUG=chromium:592692, chromium:595265 R=ishell@chromium.org LOG=n Committed: https://crrev.com/479a2df31a5c68eab494814042e2169b8163830e Cr-Commit-Position: refs/heads/master@{#34842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-16 19:02:41 UTC) #1
Benedikt Meurer
Hey Igor, Here's an optimization to bring JS runtime call support in Crankshaft to the ...
4 years, 9 months ago (2016-03-16 19:03:57 UTC) #2
Igor Sheludko
lgtm
4 years, 9 months ago (2016-03-16 21:18:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807003002/1
4 years, 9 months ago (2016-03-16 21:18:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 21:20:43 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 21:21:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/479a2df31a5c68eab494814042e2169b8163830e
Cr-Commit-Position: refs/heads/master@{#34842}

Powered by Google App Engine
This is Rietveld 408576698