Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: remoting/client/chromoting_client.cc

Issue 1806963002: Reduce APK size by disabling WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add condition for GYP Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/chromoting_client.cc
diff --git a/remoting/client/chromoting_client.cc b/remoting/client/chromoting_client.cc
index 1f7165ab5db91f8a8a5b2f59b467e9bf7f02e8c3..3aefc9fe6988d0484cfae9850631228b798453a9 100644
--- a/remoting/client/chromoting_client.cc
+++ b/remoting/client/chromoting_client.cc
@@ -72,11 +72,11 @@ void ChromotingClient::Start(
if (!connection_) {
if (protocol_config_->webrtc_supported()) {
DCHECK(!protocol_config_->ice_supported());
-#if defined(OS_NACL)
- LOG(FATAL) << "WebRTC is not supported in webapp.";
-#else // defined(OS_NACL)
+#if !defined(ENABLE_WEBRTC_REMOTING_CLIENT) // !defined(ENABLE_WEBRTC_REMOTING_CLIENT)
Sergey Ulanov 2016/03/16 23:15:07 Don't need the comment.
Yuwei 2016/03/16 23:31:55 Acknowledged.
Yuwei 2016/03/16 23:58:18 Done.
+ LOG(FATAL) << "WebRTC is not supported";
Sergey Ulanov 2016/03/16 23:15:07 nit: add . at the end of the message.
Yuwei 2016/03/16 23:31:55 Acknowledged.
Yuwei 2016/03/16 23:58:18 Done.
+#else
connection_.reset(new protocol::WebrtcConnectionToHost());
-#endif // !defined(OS_NACL)
+#endif // defined(ENABLE_WEBRTC_REMOTING_CLIENT)
Sergey Ulanov 2016/03/16 23:15:07 nit: add comment for the #else statement or remove
Yuwei 2016/03/16 23:31:55 Acknowledged.
Yuwei 2016/03/16 23:58:18 Done.
} else {
DCHECK(protocol_config_->ice_supported());
connection_.reset(new protocol::IceConnectionToHost());

Powered by Google App Engine
This is Rietveld 408576698