remoting/client/chromoting_client.cc - Issue 1806963002: Reduce APK size by disabling WebRTC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/chromoting_client.cc

Issue 1806963002: Reduce APK size by disabling WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change macro name, use separate config Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/chromoting_client.cc

diff --git a/remoting/client/chromoting_client.cc b/remoting/client/chromoting_client.cc

index 1f7165ab5db91f8a8a5b2f59b467e9bf7f02e8c3..37b0d6cc7d0ea1743761b90d7ca5d85be5429602 100644

--- a/remoting/client/chromoting_client.cc

+++ b/remoting/client/chromoting_client.cc

@@ -74,9 +74,9 @@ void ChromotingClient::Start(

DCHECK(!protocol_config_->ice_supported());

#if defined(OS_NACL)

Sergey Ulanov 2016/03/16 21:01:18 Please see my previous comment. We no longer need

LOG(FATAL) << "WebRTC is not supported in webapp.";

-#else // defined(OS_NACL)

+#elif defined(ENABLE_WEBRTC_REMOTING_CLIENT) // defined(OS_NACL)

connection_.reset(new protocol::WebrtcConnectionToHost());

-#endif // !defined(OS_NACL)

+#endif // !defined(OS_NACL) && !defined(ENABLE_WEBRTC_REMOTING_CLIENT)

} else {

DCHECK(protocol_config_->ice_supported());

connection_.reset(new protocol::IceConnectionToHost());

« no previous file with comments | « remoting/client/BUILD.gn ('k') | remoting/client/jni/chromoting_jni_instance.cc » ('j') | no next file with comments »