Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: remoting/client/chromoting_client.cc

Issue 1806963002: Reduce APK size by disabling WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/chromoting_client.cc
diff --git a/remoting/client/chromoting_client.cc b/remoting/client/chromoting_client.cc
index 1f7165ab5db91f8a8a5b2f59b467e9bf7f02e8c3..ab93887331839ff92eb75fffbc5477f202f5e54f 100644
--- a/remoting/client/chromoting_client.cc
+++ b/remoting/client/chromoting_client.cc
@@ -74,9 +74,9 @@ void ChromotingClient::Start(
DCHECK(!protocol_config_->ice_supported());
#if defined(OS_NACL)
LOG(FATAL) << "WebRTC is not supported in webapp.";
Sergey Ulanov 2016/03/16 19:12:36 We want this LOG(FATAL) on all platforms: #if !def
Yuwei 2016/03/16 21:21:00 Done.
-#else // defined(OS_NACL)
+#elif !defined(DISABLE_WEBRTC) // defined(OS_NACL)
connection_.reset(new protocol::WebrtcConnectionToHost());
-#endif // !defined(OS_NACL)
+#endif // !defined(OS_NACL) && !defined(DISABLE_WEBRTC)
} else {
DCHECK(protocol_config_->ice_supported());
connection_.reset(new protocol::IceConnectionToHost());

Powered by Google App Engine
This is Rietveld 408576698