Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/template-expected.cc

Issue 1806903003: Don't rename references to functions that originate from template args. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a period and GetType Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/template-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/template-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/template-expected.cc
index 39ae4e5efbf726abe3dfc5e29cea2c4a5a138ff8..f36b382aa967c09c89b281ee8e13ceb2387dcf6a 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/template-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/template-expected.cc
@@ -2,6 +2,20 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+namespace not_blink {
+
+void notBlinkFunction(int x) {}
+
+class NotBlinkClass {
+ public:
+ void notBlinkMethod() {}
+};
+
+template <typename T>
+void notBlinkFunctionTemplate(T x) {}
+
+} // not_blink
+
namespace blink {
template <typename T, int number>
@@ -20,4 +34,68 @@ void F() {
const int is_a_const = number;
}
+namespace test_template_arg_is_function {
+
+void F(int x) {}
+
+template <typename T, void g(T)>
+void H(T x) {
+ g(x);
+}
+
+void Test() {
+ // f should be rewritten.
+ H<int, F>(0);
+ // notBlinkFunction should stay the same.
+ H<int, not_blink::notBlinkFunction>(1);
+}
+
+} // namespace test_template_arg_is_function
+
+namespace test_template_arg_is_method {
+
+class BlinkClass {
+ public:
+ void Method() {}
+};
+
+template <typename T, void (T::*g)()>
+void H(T&& x) {
+ (x.*g)();
+}
+
+void Test() {
+ // method should be rewritten.
+ H<BlinkClass, &BlinkClass::Method>(BlinkClass());
+ H<not_blink::NotBlinkClass, &not_blink::NotBlinkClass::notBlinkMethod>(
+ not_blink::NotBlinkClass());
+}
+
+} // namespace test_template_arg_is_method
+
+// Test template arguments that are function templates.
+template <typename T, char converter(T)>
+unsigned ReallyBadHash(const T* data, unsigned length) {
+ unsigned hash = 1;
+ for (unsigned i = 0; i < length; ++i) {
+ hash *= converter(data[i]);
+ }
+ return hash;
+}
+
+struct StringHasher {
+ static unsigned Hash(const char* data, unsigned length) {
+ // TODO(dcheng): For some reason, brokenFoldCase gets parsed as an
+ // UnresolvedLookupExpr, so this doesn't get rewritten. Meh. See
+ // https://crbug.com/584408.
+ return ReallyBadHash<char, brokenFoldCase<char>>(data, length);
+ }
+
+ private:
+ template <typename T>
+ static char BrokenFoldCase(T input) {
+ return input - ('a' - 'A');
+ }
+};
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698