Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 1806893002: Reland PPC portion of "Detect cache line size on Linux for PPC hosts." (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland PPC portion of "Detect cache line size on Linux for PPC hosts." This version does not modify arm64. R=jkummerow@chromium.org, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/042f09a95c63beffcadeebc955f7674cdc01c818 Cr-Commit-Position: refs/heads/master@{#34827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -50 lines) Patch
M src/arm/assembler-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/assembler.h View 2 chunks +10 lines, -4 lines 0 comments Download
M src/assembler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/cpu.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/base/cpu.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/ppc/cpu-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-16 15:16:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806893002/1
4 years, 9 months ago (2016-03-16 15:16:27 UTC) #3
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-16 15:44:02 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 15:55:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806893002/1
4 years, 9 months ago (2016-03-16 16:25:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 16:27:45 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 16:29:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/042f09a95c63beffcadeebc955f7674cdc01c818
Cr-Commit-Position: refs/heads/master@{#34827}

Powered by Google App Engine
This is Rietveld 408576698