Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1806883003: Make prettyprinting of variable proxies clearer. (Closed)

Created:
4 years, 9 months ago by neis
Modified:
4 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make prettyprinting of variable proxies clearer. If the variable is unallocated, say so. This CL also fixes the return value of FormatSlotNode. R=mvstanton@chromium.org TBR=rossberg@chromium.org BUG= Committed: https://crrev.com/8bff1a25c876b66959fe7efd8685f81b2ae30b30 Cr-Commit-Position: refs/heads/master@{#34846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/ast/prettyprinter.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
neis
4 years, 9 months ago (2016-03-17 08:15:55 UTC) #1
mvstanton
lgtm
4 years, 9 months ago (2016-03-17 08:48:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806883003/1
4 years, 9 months ago (2016-03-17 08:53:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12496)
4 years, 9 months ago (2016-03-17 09:01:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806883003/1
4 years, 9 months ago (2016-03-17 09:05:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 09:17:10 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 09:18:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bff1a25c876b66959fe7efd8685f81b2ae30b30
Cr-Commit-Position: refs/heads/master@{#34846}

Powered by Google App Engine
This is Rietveld 408576698