Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1806853006: Fix autofill wallet metadata notification type. (Closed)

Created:
4 years, 9 months ago by please use gerrit instead
Modified:
4 years, 9 months ago
Reviewers:
Nicolas Zea, skym
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org, kevinliu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix autofill wallet metadata notification type. Autofill wallet metadata notification identifier should be "WALLET_METADATA" instead of "AUTOFILL_WALLET_METADATA" on the client side to match the server side sync. The server uses the name of the protobuf WalletMetadataSpecifics to derive the identifier. This affects only wallet metadata update notifications. BUG=593546 Committed: https://crrev.com/c924e6daca48ca588062d674958e81fcdb75bb94 Cr-Commit-Position: refs/heads/master@{#381828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sync/syncable/model_type.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
please use gerrit instead
Sky, ptal.
4 years, 9 months ago (2016-03-17 19:08:18 UTC) #2
skym
lgtm
4 years, 9 months ago (2016-03-17 20:04:55 UTC) #3
please use gerrit instead
Nicolas, owners ptal.
4 years, 9 months ago (2016-03-17 20:34:01 UTC) #5
Nicolas Zea
LGTM
4 years, 9 months ago (2016-03-17 23:05:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806853006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806853006/1
4 years, 9 months ago (2016-03-17 23:10:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 23:17:08 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 23:18:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c924e6daca48ca588062d674958e81fcdb75bb94
Cr-Commit-Position: refs/heads/master@{#381828}

Powered by Google App Engine
This is Rietveld 408576698