Promote {Add,Clear}ServiceOverrideForTesting to ServiceRegistry public interface.

Promote {Add,Clear}ServiceOverrideForTesting to ServiceRegistry public interface.

Currently {Add,Clear}ServiceOverrideForTesting are only visible from
ServiceRegistryImpl, so they can't be employed by mojo interfaces
testing code from outside of //content.

This CL promotes them to ServiceRegistry public interface to solve the
problem.

BUG=none

Committed: https://crrev.com/94f8dd35588166f03a064f826fe35fd636d59337
Cr-Commit-Position: refs/heads/master@{#382190}

[leonhsl(Using Gerrit), 2016-03-18 05:41:02]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 05:41:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806843005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806843005/1

[commit-bot: I haz the power, 2016-03-18 07:15:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 07:15:20]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2016-03-18 10:36:15]

leon.han@intel.com changed reviewers:
+ jam@chromium.org

[leonhsl(Using Gerrit), 2016-03-18 10:36:15]

Would you PTAL, Thanks~

[jam, 2016-03-18 17:01:13]

lgtm

https://codereview.chromium.org/1806843005/diff/1/content/public/common/servi...
File content/public/common/service_registry.h (right):

https://codereview.chromium.org/1806843005/diff/1/content/public/common/servi...
content/public/common/service_registry.h:71: virtual void
ClearServiceOverridesForTesting() = 0;
nit: document

[leonhsl(Using Gerrit), 2016-03-19 05:05:12]

Thanks a lot! Addressed nit and will land. Thanks~

https://codereview.chromium.org/1806843005/diff/1/content/public/common/servi...
File content/public/common/service_registry.h (right):

https://codereview.chromium.org/1806843005/diff/1/content/public/common/servi...
content/public/common/service_registry.h:71: virtual void
ClearServiceOverridesForTesting() = 0;
On 2016/03/18 17:01:13, jam wrote:
> nit: document

Done.

[leonhsl(Using Gerrit), 2016-03-19 05:05:32]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2016-03-19 05:05:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1806843005/#ps20001
(title: "Address nit.")

[commit-bot: I haz the power, 2016-03-19 05:05:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806843005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806843005/20001

[commit-bot: I haz the power, 2016-03-19 06:40:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-19 06:53:39]

Description was changed from

==========
Promote {Add,Clear}ServiceOverrideForTesting to ServiceRegistry public
interface.

Currently {Add,Clear}ServiceOverrideForTesting are only visible from
ServiceRegistryImpl, so they can't be employed by mojo interfaces
testing code from outside of //content.

This CL promotes them to ServiceRegistry public interface to solve the
problem.

BUG=none
==========

to

==========
Promote {Add,Clear}ServiceOverrideForTesting to ServiceRegistry public
interface.

Currently {Add,Clear}ServiceOverrideForTesting are only visible from
ServiceRegistryImpl, so they can't be employed by mojo interfaces
testing code from outside of //content.

This CL promotes them to ServiceRegistry public interface to solve the
problem.

BUG=none

Committed: https://crrev.com/94f8dd35588166f03a064f826fe35fd636d59337
Cr-Commit-Position: refs/heads/master@{#382190}
==========

[commit-bot: I haz the power, 2016-03-19 06:53:41]

Patchset 2 (id:??) landed as
https://crrev.com/94f8dd35588166f03a064f826fe35fd636d59337
Cr-Commit-Position: refs/heads/master@{#382190}