Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180683003: MediaStream API: Addding support for UA specific error messages for gUM (Closed)

Created:
6 years, 9 months ago by Tommy Widenflycht
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, philipj_slow, dglazkov+blink, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org
Visibility:
Public.

Description

MediaStream API: Addding support for UA specific error messages for gUM The spec now says that getUserMedia error messages are UA specific with the exception for PermissionDeniedError and ConstraintNotSatisfied. BUG=132812 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -19 lines) Patch
M Source/modules/mediastream/NavigatorUserMediaError.h View 1 chunk +7 lines, -4 lines 0 comments Download
M Source/modules/mediastream/NavigatorUserMediaError.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 1 chunk +14 lines, -4 lines 0 comments Download
M Source/web/WebUserMediaRequest.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
M public/web/WebUserMediaRequest.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Tommy Widenflycht
6 years, 9 months ago (2014-03-03 16:18:59 UTC) #1
Tommy Widenflycht
6 years, 9 months ago (2014-03-04 08:31:34 UTC) #2
abarth-chromium
This seems like a bit of an interoperability copout, but otherwise LGTM
6 years, 9 months ago (2014-03-04 18:45:43 UTC) #3
Tommy Widenflycht
The CQ bit was checked by tommyw@chromium.org
6 years, 9 months ago (2014-03-05 07:47:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/180683003/1
6 years, 9 months ago (2014-03-05 07:49:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/180683003/1
6 years, 9 months ago (2014-03-05 20:57:13 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 03:58:38 UTC) #7
Message was sent while issue was closed. 
Change committed as 168562

Powered by Google App Engine
This is Rietveld 408576698