Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1806813004: Fix smartclip crash (Closed)

Created:
4 years, 9 months ago by Changwan Ryu
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix smartclip crash Left upper corner of the rect may not always be the starting position in the DOM hierarchy, and this assumption was causing crashes. BUG=589082 Committed: https://crrev.com/cddc46848415206666281dfb0cefbb8eba1f7aed Cr-Commit-Position: refs/heads/master@{#381838}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/smartclip_reversed_positions.html View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Changwan Ryu
PTAL
4 years, 9 months ago (2016-03-17 06:34:30 UTC) #2
yosin_UTC9
lgtm
4 years, 9 months ago (2016-03-17 06:52:53 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 9 months ago (2016-03-17 18:52:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806813004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806813004/40001
4 years, 9 months ago (2016-03-17 23:37:20 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-17 23:44:52 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 23:45:57 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cddc46848415206666281dfb0cefbb8eba1f7aed
Cr-Commit-Position: refs/heads/master@{#381838}

Powered by Google App Engine
This is Rietveld 408576698