Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1806813003: Ensures that any accessibility attributes on Windows whose values have not been specified get a def… (Closed)

Created:
4 years, 9 months ago by nektarios
Modified:
4 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensures that any accessibility attributes on Windows whose values have not been specified get a default value in tests. BUG=508794 R=dmazzoni@chromium.org Committed: https://crrev.com/4aedd4df4e2cbad0a315cf8bbb2bc5787a77ff02 Cr-Commit-Position: refs/heads/master@{#381568}

Patch Set 1 #

Patch Set 2 : Removed suppressions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -28 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 1 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nektarios
4 years, 9 months ago (2016-03-16 20:59:15 UTC) #1
dmazzoni
lgtm Could you try removing the suppression as part of this change? Then run it ...
4 years, 9 months ago (2016-03-16 21:17:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806813003/20001
4 years, 9 months ago (2016-03-16 21:30:01 UTC) #4
chromium-reviews
Done. I'll try submitting via the bots. -- You received this message because you are ...
4 years, 9 months ago (2016-03-16 21:30:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806813003/20001
4 years, 9 months ago (2016-03-16 21:39:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 22:24:11 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 22:29:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4aedd4df4e2cbad0a315cf8bbb2bc5787a77ff02
Cr-Commit-Position: refs/heads/master@{#381568}

Powered by Google App Engine
This is Rietveld 408576698