Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: test/webkit/dfg-array-pop-side-effects.js

Issue 18068003: Migrated several tests from blink to V8 repository. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/webkit/dfg-array-length-dead-expected.txt ('k') | test/webkit/dfg-array-pop-side-effects-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/webkit/dfg-array-pop-side-effects.js
diff --git a/test/webkit/concat-while-having-a-bad-time.js b/test/webkit/dfg-array-pop-side-effects.js
similarity index 62%
copy from test/webkit/concat-while-having-a-bad-time.js
copy to test/webkit/dfg-array-pop-side-effects.js
index dfda1e08a0b36194b787a44ee12a9693acd8aeaf..8d4d5f319a57a3015a3f454a9b06a865ab25dc94 100644
--- a/test/webkit/concat-while-having-a-bad-time.js
+++ b/test/webkit/dfg-array-pop-side-effects.js
@@ -22,10 +22,41 @@
// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
description(
-"Tests the behavior of Array.prototype.concat while the array is having a bad time due to one of the elements we are concatenating."
+"Tests that ArrayPop is known to the DFG to be a side effect."
);
-Object.defineProperty(Array.prototype, 0, { writable: false });
-shouldBe("[42].concat()", "[42]");
+function foo(a, b) {
+ var result = a.f;
+ result += b.pop();
+ result += a.g;
+ return result;
+}
+var ouches = 0;
+for (var i = 0; i < 200; ++i) {
+ var a = {f:1, g:2};
+ var b = [];
+ var expected;
+ if (i < 150) {
+ // Ensure that we always transition the array's structure to one that indicates
+ // that we have array storage.
+ b.__defineGetter__("0", function() {
+ testFailed("Should never get here");
+ });
+ b.length = 0;
+ b[0] = 42;
+ expected = "45";
+ } else {
+ b.__defineGetter__("0", function() {
+ debug("Ouch!");
+ ouches++;
+ delete a.g;
+ a.h = 43;
+ return 5;
+ });
+ expected = "0/0";
+ }
+ shouldBe("foo(a, b)", expected);
+}
+shouldBe("ouches", "50");
« no previous file with comments | « test/webkit/dfg-array-length-dead-expected.txt ('k') | test/webkit/dfg-array-pop-side-effects-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698