Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: test/webkit/sort-randomly.js

Issue 18068003: Migrated several tests from blink to V8 repository. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/webkit/sort-non-numbers-expected.txt ('k') | test/webkit/sort-randomly-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/webkit/sort-randomly.js
diff --git a/test/webkit/concat-while-having-a-bad-time.js b/test/webkit/sort-randomly.js
similarity index 69%
copy from test/webkit/concat-while-having-a-bad-time.js
copy to test/webkit/sort-randomly.js
index dfda1e08a0b36194b787a44ee12a9693acd8aeaf..bd1847262b24aa820b7377a8fd860c95ad32a837 100644
--- a/test/webkit/concat-while-having-a-bad-time.js
+++ b/test/webkit/sort-randomly.js
@@ -22,10 +22,24 @@
// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
description(
-"Tests the behavior of Array.prototype.concat while the array is having a bad time due to one of the elements we are concatenating."
+"This tests that passing an inconsistent compareFn to sort() doesn't cause a crash."
);
-Object.defineProperty(Array.prototype, 0, { writable: false });
-shouldBe("[42].concat()", "[42]");
+for (var attempt = 0; attempt < 100; ++attempt) {
+ var arr = [];
+ for (var i = 0; i < 64; ++i)
+ arr[i] = i;
+ arr.sort(function() { return 0.5 - Math.random(); });
+}
+// Sorting objects that change each time sort() looks at them is the same as using a random compareFn.
+function RandomObject() {
+ this.toString = function() { return (Math.random() * 100).toString(); }
+}
+for (var attempt = 0; attempt < 100; ++attempt) {
+ var arr = [];
+ for (var i = 0; i < 64; ++i)
+ arr[i] = new RandomObject;
+ arr.sort();
+}
« no previous file with comments | « test/webkit/sort-non-numbers-expected.txt ('k') | test/webkit/sort-randomly-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698